Mark the files found during node_modules search correctly when reusing program structure completely#19435
Merged
sheetalkamat merged 2 commits intomasterfrom Oct 24, 2017
Merged
Conversation
mhegazy
approved these changes
Oct 24, 2017
Contributor
|
Please port this to release-2.6 |
This was referenced Oct 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix the source files reused from node_modules folder that weren't part of program output structure were used as normal files in new program resulting in incorrect errors and incorrect program output structure
Fixes #19327
I also think this might be fix for #19280, #19290